Fix typo, use rancher/permissions
#10296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harrison Affel <harrisonaffel@gmail.com>
brandond
approved these changes
Jun 5, 2024
manuelbuil
approved these changes
Jun 6, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10296 +/- ##
==========================================
- Coverage 47.78% 41.69% -6.10%
==========================================
Files 177 177
Lines 14801 14801
==========================================
- Hits 7073 6171 -902
- Misses 6383 7451 +1068
+ Partials 1345 1179 -166
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixes a typo in
config.goand removes the windows specific ACL logic in favor of therancher/permissionslibrary. The logic inacl/acl_windows.gowas taken directly fromrancher/permissions, so there is no functional difference, this is simply addressing tech debt.Types of Changes
Bugfix
Verification
Create a Windows cluster and ensure the proper ACL is set
Testing
This change is not yet covered by a unit test
Linked Issues
User-Facing Change
Further Comments